Skip to content

Conversation

@Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Sep 3, 2022

  • Support for upload client certificates during tenant creation
  • Support for adding client certificates for existing tenants
  • Don't restart all pods at the same time when updating security
    configuration, instead do rollout restart

Screenshot from 2022-09-02 17-53-15

Screenshot from 2022-09-02 17-53-45

Signed-off-by: Lenin Alevski [email protected]

Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alevsk Alevsk force-pushed the client-cert-support branch from d79def0 to 3bfc7a1 Compare September 3, 2022 01:13
@bexsoft bexsoft added the needed High Priority label Sep 3, 2022
@Alevsk Alevsk force-pushed the client-cert-support branch 2 times, most recently from 7783862 to b0127c1 Compare September 3, 2022 21:49
- Support for upload client certificates during tenant creation
- Support for adding client certificates for existing tenants
- Don't restart all pods at the same time when updating security
  configuration, instead do rollout restart
- Adding `parseTenantCertificates` function tests

Signed-off-by: Lenin Alevski <[email protected]>
@Alevsk Alevsk force-pushed the client-cert-support branch from b0127c1 to 2541e3c Compare September 3, 2022 22:00
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cniackz
Copy link
Collaborator

cniackz commented Sep 6, 2022

Screen Shot 2022-09-06 at 10 45 08 AM

I see console errors, but some are related to other PR, like: #2139

I will fix some of these console errors in a separate PR.

@cniackz
Copy link
Collaborator

cniackz commented Sep 6, 2022

Tested locally:

  • Scenario when they match:

Screen Shot 2022-09-06 at 10 52 36 AM

  • Scenario when they don't match:

Screen Shot 2022-09-06 at 10 53 24 AM

Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 989f041 into minio:master Sep 6, 2022
@Alevsk Alevsk deleted the client-cert-support branch September 6, 2022 16:02
@djwfyi djwfyi mentioned this pull request Sep 7, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needed High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants